fix: default display/unverified reads to include_proof:false#5
Merged
Conversation
graphql_query() gains an include_proof=False param and sends it on the body (previously never sent, so the server defaulted to true); sql_query()'s default flips True->False. Verified data.query()/get(), query_historical_verified(), and eth-state verifiable-rpc are unchanged and still fail closed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Plain display reads omitted
include_proof, and the server defaults an absent flag totrue— so every display read paid per-entity Merkle proving plus the proof-consistency retry loop (measured ~22× bytes, 2–4× latency on an idle indexer) and then discarded a proof it never verified. This sendsinclude_proof: falseexplicitly on the SQL and GraphQL display paths.Verification APIs are untouched and still fail closed:
data.query()still forcesTrueand verifies against the consensus root,query_historical_verified()still forces proof, and theeth_stateverifiable-rpc reads are unchanged.This repo
IndexingOperations.graphql_query()gains aninclude_proof: bool = Falseparam and sets it on the request body (previously never sent the field).IndexingOperations.sql_query()default flipsTrue→False. Callers opt back in withinclude_proof=True.Verification
pip install -e .[dev]+pytest→ 288 passed / 13 pre-existing integration skips, including 4 new wire tests assertinginclude_proof=falsereaches the body by default.mypy srcintroduces zero new errors (150-error baseline is identical with and without this diff — unrelated repo tech debt). No verification API changed.Closes the "SDK display reads: pass
include_proof: false" task.🤖 Generated with Claude Code